Cruise Control Questions

Just tested it on 5.3 with ADC+UART Current No Reverse Brake ADC2 and it works when PPM/Servo input is shorted to the ground. The button state is read in the code snippet below in the adc.c file. Depending on what the control mode is selected the PPM pin is assigned to be the cruise control button or the reverse button. If Inverted is selected in the app configuration, the cruise control or reverse is activated by shorting the PPM to 3.3v. The cruise stays activated while the wires are connected and turns off when they are disconnected, so you have to either use two position button or a push button and keep it pressed if for cruise. The first approach would likely be unsafe as cruise disengagement would depend on depressing the button and the second likely works fine for skateboards with the remote control held by a ride at all times but will be inconvenient on bikes, cars, etc. as it requires the push button to be pressed all the time to continue. I'll be adding some code to make the cruise button a toggle switch that also gets canceled on other events like brakes, throttle changes, etc. It might be also good to use the same cruise button for reverse by using long press (5 sec or so).

if (config.ctrl_type == ADC_CTRL_TYPE_CURRENT_REV_BUTTON ||
config.ctrl_type == ADC_CTRL_TYPE_CURRENT_REV_BUTTON_BRAKE_CENTER ||
config.ctrl_type == ADC_CTRL_TYPE_CURRENT_NOREV_BRAKE_BUTTON ||
config.ctrl_type == ADC_CTRL_TYPE_DUTY_REV_BUTTON ||
config.ctrl_type == ADC_CTRL_TYPE_PID_REV_BUTTON) {
rev_button = !palReadPad(HW_ICU_GPIO, HW_ICU_PIN);
if (config.rev_button_inverted) {
rev_button = !rev_button;
}
} else {

cc_button = !palReadPad(HW_ICU_GPIO, HW_ICU_PIN);
if (config.cc_button_inverted) {
cc_button = !cc_button;
}
}
}